GitLab

Fixes #1828

The code quality of it is terrible, the user experience of using it is terrible, and it should have been removed years ago

Closes #2090
Fixes #1851

Closes #2113

This cannot be triggered by any user generally.

Fixes #2128

Note that this is unlikely to be triggerable by another user.

Thanks to @dequis for discovering.

This is required for Flatpak but is an API break so it is opt-in
for now.

Fixes #2121

This should be slower but pango seems to be reasonably fast
on Unix though extremely slow on Windows.

https://bugzilla.redhat.com/show_bug.cgi?id=1536298

They changed the lib name yet again...

Closes #2117

The path where appdata/appstream files should be installed has been
changed from /usr/share/appdata/ to /usr/share/metainfo/.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-locationSigned-off-by: Mattia Rizzolo <mattia@mapreri.org>

This patch hopefully solves a bug that causes that when a tab (channel or private) is left with the scrollbar at the bottom, and some new text arrives, and then we select again that tab, sometimes the scrollbar is not completely down and there is hidden text and we have to scroll manually to the bottom to show all text.
This was previously submitted as an issue in: https://github.com/hexchat/hexchat/issues/1948
Maybe it isn't the ideal way to solve it, but at least I tested it and it seems to work.

RDNS syntax is recommended for applications and this matches the
existing flatpak. Note that the dbus service and icons still need
renaming though the former is an API breakage.

Closes #2104
Closes #2103

- Add logging and error handling to loading symbols
- Don't load unversioned symbol
- Handle new function names in Enchant 2.0

Closes #2095

This is some meson bug but this solution works for now.

For some reason on my system `libpci` is found even though its not
installed...? Plus I forgot a few headers being included.

Turns out libpci is an awful library that on any error calls
exit() and has no way of indicating an error otherwise...

Fixes #2084

word[4] can be too short, leading to the addition of ctcp_offset
putting us out of bounds. This results in an oob read in ctcp_check.

This change adds an option `irc_reconnect_rejoin` (default ON)
which when turned OFF will prevent hexchat from rejoining channels
after an auto reconnect.

hexchat/hexchat#2069

Cutting off all text after \001 can result in users hiding text
so lets only bother handling it if it is a valid CTCP message
(starting and ending with \001).

If n becomes 0 at the same time that the end of either s1 or s2 are
reached, the next iteration of the while loop wouldn't happen, so we
wouldn't correctly return 0.

It is common for users to set "foo, bar" and the leading space
has caused issues in the past so lets just ignore that.

rfc_casecmp was broken because reaching terminator for str1 was used as
a terminal condition and str2 may be shorter than str1, resulting in an
oob read condition for str2.

rfc_ncasecmp was broken because it checked if n characters were checked
or if BOTH pointers reached their terminator, however the strings may
be different lengths and also less than n characters in length, meaning
that they don't both reach their terminators at the same time,
resulting in an oob read condition.

If ptr[0] is NULL, then strchr may return a pointer to the NULL
terminator for serv->nick_prefixes, making the if statement true, which
then leads to the pointer increment leaving ptr oob. Now we check to
ensure ptr[0] != NULL.

From the Linux manpages for strchr:
The terminating null byte is considered part of the string, so that if c is
       specified as '\0', these functions return a pointer to the terminator.

* Spelling: SOCKS5

* SOCKS4/5, Byte per second

As per https://en.wikipedia.org/wiki/Data_rate_units