Commit 49e77406 authored by Cool Fire's avatar Cool Fire

Fix another 2.3 compatibility bug and run rack tests for 2.3 too.

parent bbc2724d
Pipeline #380 passed with stages
in 2 minutes and 9 seconds
......@@ -40,7 +40,7 @@ lint_yaml:
script:
- gem install yamllint --no-ri --no-rdoc
- yamllint content/*.yaml
rack_test:
rack_test_2-4:
stage: testing
image: ruby:2.4-alpine
script:
......@@ -48,6 +48,14 @@ rack_test:
- bundle install
- touch .current
- ruby test.rb
rack_test_2-3:
stage: testing
image: ruby:2.3-alpine
script:
- gem install simplecov rack-test --no-ri --no-rdoc
- bundle install
- touch .current
- ruby test.rb
deploy_to_production:
stage: deploy
image: ubuntu:16.04
......@@ -69,4 +77,4 @@ deploy_to_production:
- bash deployment/set_git_tag.sh
- bash deployment/populate_config.sh
- bash deployment/restart_application.sh
- curl -XPOST nanoapi.insomnia247.nl/v1/message -d "key=$NANOBOT_API_KEY&dest=#shells@&message=Deployed new version of signup-site."
- curl -XPOST nanoapi.insomnia247.nl/v1/message -d "key=$NANOBOT_API_KEY&dest=#shells@&message=Deployed new version of signup-site to production."
......@@ -50,7 +50,7 @@ class SignupSite < Sinatra::Base
number.gsub!(/^(00|\+)/, '')
# Check for stray characters
return false if number.match?(/^\d+$/)
return false unless number.match(/^\d+$/).nil?
# Check with messagebird HLR if the phone number is valid
# TODO: Actually implement HLR lookup.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment